Skip to content

BTLx_Flip_Beam#2

Open
obucklin wants to merge 99 commits intomainfrom
BTLx_Flip_Beam
Open

BTLx_Flip_Beam#2
obucklin wants to merge 99 commits intomainfrom
BTLx_Flip_Beam

Conversation

@obucklin
Copy link
Collaborator

This adds a feature to make multiple BTLx files for a single beam to allow for flipping. It automatically puts the processings at the start of the beam in the last BTLx file so that we have a consistent beam end for positioning on the mill.

Not sure if this is still useful, just thought I'd submit a PR before it became too outdated.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants